Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Blueprint execution in the browser when persistent storage is used #1484

Closed
wants to merge 4 commits into from

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Jun 2, 2024

Skips the Blueprint execution when WordPress is loaded from an external source. Running the same Blueprint twice installing the same plugins, overwriting the files etc. would just lead to corrupting the WordPress instance.

Testing instructions

  1. Go to this local Playground URL.
  2. Confirm it loads the block editor
  3. Refresh the page
  4. Confirm it loaded without installing WordPress and that it still worked and there were no conflicts arount the classic-editor plugin

adamziel added 2 commits June 2, 2024 23:52
Skips the Blueprint execution when WordPress is loaded from an external source.
Running the same Blueprint twice installing the same plugins, overwriting the files etc.
would just lead to corrupting the WordPress instance.

 ## Testing instructions

1. Go to this [local Playground URL](http://localhost:5400/website-server/?storage=browser#{%22login%22:true,%20%22plugins%22:[%22classic-editor%22],%20%22landingPage%22:%22/wp-admin/post-new.php%22}).
2. Confirm it loads the block editor
3. Refresh the page
4. Confirm it loaded without installing WordPress and that it still
   worked and there were no conflicts arount the classic-editor plugin
@adamziel adamziel mentioned this pull request Jul 1, 2024
@adamziel adamziel mentioned this pull request Aug 1, 2024
@adamziel adamziel force-pushed the trunk branch 2 times, most recently from 680cd19 to 2e376d2 Compare October 4, 2024 09:24
@adamziel
Copy link
Collaborator Author

adamziel commented Oct 7, 2024

With #1561 and #1854, Blueprints are only used for creating new temporary sites. This PR is no longer needed.

@adamziel adamziel closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants